Plpeople popups #453
Merged
Plpeople popups #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, I'm sorry! Looks like you got it working, and @crisner got the text failure to work with another mock. 🎉 |
|
Ah, so awesome! OK, just rebased!!! |
|
Thanks @nstjean no problem!!! |
|
DONE! Yay!!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on and replacing #422
Citing that PR by @nstjean --
Fixes #421 (<=== Add issue number here)
This depends entirely on publiclab/leaflet-blurred-location-display#96 and cannot be merged until that PR is merged and published in LBLD.
The "Joined [time ago]" depends on new data added to the API in plots2: publiclab/plots2#7562
This is what the new popups look like: